-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add Root Fingerprint to Output #23
Comments
Thanks for this feature request. I'd be happy to implement it, seems straightforward. Agree that it would fit under |
Forgot to mention my own code snippet in golang to calculate this (just research code not cleaned up yet, but in case it helps)! |
I'm not so good at python (or golang), so I thought I'd look up the standard recipe for cooking a root fingerprint. Is this in any of the BIPs? I couldn't find it. |
There isn't really, it's just something coldcard picked up for registering xpubs in a multisig and then Spectre copied :( Maybe this 2-line code snippet is more clear? It's the master parent |
This was really helpful, thanks! |
This is implemented on seedpicker.net now (Cache reset may be necessary). |
The functionality looks great, thanks! I tested it against my python and golang scripts for I did notice a security vulnerability on this PR that I think should be addressed ASAP: |
Btw, I'm closing this as it's done, right? Love the new feature! |
It turns out this is required for interoperability with Coldcard as well as Spectre.
The easiest way to do this now is as follows, but it's obviously sketchy (destroys much of the security benefit of seedpicker!):
abandon
repeated 23x here (will correctly returnart
):http://seedpicker.net/calculator/last-word.html
Code snippet on how to calculate root fingerpint here:
https://github.com/spesmilo/electrum/blob/9d0bb295e6f55a2bff9f5b6770fa744c16af6e8a/electrum/keystore.py#L685-L690
This one may be easier to read:
https://github.com/lyndsysimon/bip32utils/blob/56f5a56d1c54e648f35b670a87efabbca08fffae/bip32utils/BIP32Key.py#L244-L266
Maybe for UX purposes, you'd want to hide this behind
Show more (for advanced users)
?The text was updated successfully, but these errors were encountered: