Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flink): add command for listing flink jobs #757

Merged
merged 7 commits into from
May 31, 2023
Merged

feat(flink): add command for listing flink jobs #757

merged 7 commits into from
May 31, 2023

Conversation

jayjayjpg
Copy link
Contributor

@jayjayjpg jayjayjpg commented May 31, 2023 •
edited
Loading

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/290

With this change, we're adding the meroxa flink list command to the CLI. This way, users will be able to see a list of their already deployed Flink jobs on the platform.

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Open todos

  • add additional test cases for command failure
  • add tests for empty list
  • create demo

Demo

$ meroxa flink list
UUID                                    NAME              ENVIRONMENT       STATE             DEPLOYMENT STATE        
====================================== ================ ================== ================  ====================== 
118c7446-e60c-49a7-ac90-12e04d64df9e   my-first-flink       common           running           deployed                     
cb7a7d7c-8bb3-4549-9af7-4f9eaab9c2af   my-second-flink      common           failed            rolling back

@jayjayjpg jayjayjpg force-pushed the jj/listed-as-flink branch 2 times, most recently from 94f30c1 to b4b680c Compare May 31, 2023 09:52
@janelletavares
Copy link
Contributor

looking good

jayjayjpg and others added 4 commits May 31, 2023 17:43
@jayjayjpg @janelletavares
upd(flink): update dashboard reference in flink list output
3e3986f 
Co-authored-by: Janelle Tavares <janelletavares@users.noreply.github.com>
@jayjayjpg @janelletavares
upd(flink): reorder imports in list test
10e693c 
Co-authored-by: Janelle Tavares <janelletavares@users.noreply.github.com>
@jayjayjpg @janelletavares
upd(flink): remove obsolete append for flink jobs
7add125 
Co-authored-by: Janelle Tavares <janelletavares@users.noreply.github.com>
@jayjayjpg @janelletavares
upd(flink): improve flink list test assertions
1e73912 
Co-authored-by: Janelle Tavares <janelletavares@users.noreply.github.com>
nassor
nassor reviewed May 31, 2023
View reviewed changes
utils/display/flink_jobs.go Outdated Show resolved Hide resolved
@janelletavares janelletavares merged commit c6e1dea into master May 31, 2023
@janelletavares janelletavares deleted the jj/listed-as-flink branch May 31, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janelletavares janelletavares janelletavares approved these changes

@nassor nassor nassor approved these changes

@raulb raulb Awaiting requested review from raulb

@samirketema samirketema Awaiting requested review from samirketema

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayjayjpg @janelletavares @nassor