Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: depguard errors #760

Merged
merged 1 commit into from
Jun 2, 2023
Merged

fix: depguard errors #760

merged 1 commit into from
Jun 2, 2023

Conversation

raulb
Copy link
Member

@raulb raulb commented Jun 2, 2023

Description of change

Fixes CI errors on depguard. An alternative is disabled that check altogether...

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Tested on CI

Demo

Before

...
import 'github.com/fatih/color' is not allowed from list 'main' (depguard)
import 'github.com/briandowns/spinner' is not allowed from list 'main' (depguard)
import 'github.com/spf13/cobra' is not allowed from list 'main' (depguard)
import 'github.com/pkg/browser' is not allowed from list 'main' (depguard)
import 'github.com/spf13/cobra' is not allowed from list 'main' (depguard)
import 'github.com/spf13/cobra' is not allowed from list 'main' (depguard)
import 'github.com/spf13/cobra/doc' is not allowed from list 'main' (depguard)
import 'github.com/withfig/autocomplete-tools/integrations/cobra' is not allowed from list 'main' 
import 'github.com/gorilla/mux' is not allowed from list 'main' (depguard)
import 'github.com/google/uuid' is not allowed from list 'main' (depguard)
import 'github.com/spf13/pflag' is not allowed from list 'main' (depguard)
import 'github.com/cased/cased-go' is not allowed from list 'main' (depguard)
import 'github.com/spf13/pflag' is not allowed from list 'main' (depguard)
import 'github.com/spf13/viper' is not allowed from list 'main' (depguard)

After

No errors.

@raulb raulb requested a review from lyuboxa June 2, 2023 13:37
@raulb raulb self-assigned this Jun 2, 2023
@raulb raulb merged commit 3ef28dc into master Jun 2, 2023
@raulb raulb deleted the fix-depguard-lint branch June 2, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants