Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form file paths in an OS agnostic way #766

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Jun 7, 2023

Description of change

Update unit tests, as well, to be able to run them on any OS

Related to https://github.com/meroxa/product/issues/815

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great, thank you for the quick update on the unit tests! ✨

@janelletavares janelletavares merged commit 86f4e38 into master Jun 9, 2023
@janelletavares janelletavares deleted the os-compatibility branch June 9, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants