50 clean citations #64
Conversation
There was a problem hiding this comment.
This is great, thanks. Remaining thing is the issue mentioned on the Animate PR (mesh-adaptation/animate#160 (review)) but otherwise looks good!
docs/source/source_references.bib
Outdated
| @article{Caprio:2013, | ||
| title={Anisotropic ``goal-oriented'' mesh adaptivity for elliptic problems}, | ||
| author={Carpio, Jaime and Prieto, Juan Luis and Bermejo, Rodolfo}, |
There was a problem hiding this comment.
Typo: Should be Carpio:2013.
There was a problem hiding this comment.
@jwallwork23 - these changes should have been pushed in commit 0ff13f8. I see them on the remote branch. Is there something I missed when linking to the PR perhaps?
There was a problem hiding this comment.
There are still two instances of this incorrect spelling when I grep on the Animate branch.
docs/Makefile
Outdated
| cat ${ANIMATE}/demos/demo_references.bib >> source/references.bib | ||
| cat ${GOALIE}/demos/demo_references.bib >> source/references.bib | ||
| cat ${MOVEMENT}/demos/demo_references.bib >> source/references.bib | ||
| cat source/source_references.bib >> source/references.bib |
There was a problem hiding this comment.
Don't we want to get rid of the reference files in the other repositories and just have them in this one?
There was a problem hiding this comment.
@jwallwork23 - this was deleted in commit 0ff13f8. I see them on the remote branch. Is there something I missed when linking to the PR perhaps?
|
@jwallwork23 - I think I finally resolved the issue with the citations in animate and goalie not appearing. The last commits to animate corrected the citation errors but at no point were they referenced in a |
closes #50
should be evaluated in combination with:
mesh-adaptation/movement#132
mesh-adaptation/animate#160
mesh-adaptation/goalie#232
Locally the main warnings remaining after all the PRs should be about 'duplicate_citations', though all citations should still render.