Added triple-press GPS toggle button changes for select ESP32 devices #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jul 17, 2023
|
extensions.json should probably not be included in this commit as it removes trunk extension recommendation. However I have a similar issue in vscode... it permanently changes extensions.json and add it's own stuff. |
thebentern
reviewed
Jul 17, 2023
.vscode/extensions.json
Outdated
There was a problem hiding this comment.
Lets undo this file's changes. Otherwise, looks good.
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jul 17, 2023
|
Is it possible to disable/prevent this from occuring?
Tony
…________________________________
From: Manuel ***@***.***>
Sent: Monday, July 17, 2023 05:30
To: meshtastic/firmware ***@***.***>
Cc: tropho23 ***@***.***>; Author ***@***.***>
Subject: Re: [meshtastic/firmware] Added triple-press GPS toggle button changes for select ESP32 devices (PR #2617)
extensions.json should probably not be included in this commit as it removes trunk extension recommendation.
However I have a similar issue in vscode... it permanently changes extensions.json and add it's own stuff.
—
Reply to this email directly, view it on GitHub<#2617 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ7GUPUPWZXKSERPA6QJPHTXQUA4HANCNFSM6AAAAAA2MLKSQI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
It has been specifically included by the .gitignore file along with a few other files in that directory, but the rest of .vscode is ignored. |
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added triple-button press to disable GPS power for the below targets:
I have tested all of these changes on real hardware with no issues noted.
We could extend this to older ESP32 devices, but I don't have really old Tlora boards (v1/v2) to test. The above list, plus the existing triple-button press already implemented for T-Beam v1.1 should cover the vast majority of users.
This does not affect RAK boards, where toggling 3v3_S (by shorting IO2 to GND) disables power to ALL modules, not just GPS. I may submit another PR for consideration to address that.