Draft PR to support new device unPhone #3530
Conversation
|
|
|
|
||
| build_flags = ${esp32_base.build_flags} | ||
| -D PRIVATE_HW | ||
| -D UNPHONE |
There was a problem hiding this comment.
Just a technicality - once this is finished, please register a proper device identifier in our protobufs here. The PRIVATE_HW is only for development or unpublished ports. You can probably lose the UNPHONE define this way too.
There was a problem hiding this comment.
Ah yes, I wondered if I should do that now or later.... I'll go and put in a PR to that repo now. Thanks!
There was a problem hiding this comment.
PR against the protobufs submitted here
| Wire.write(0x04); // Backlight on | ||
| Wire.write(0x22); // G&B LEDs off | ||
| Wire.endTransmission(); | ||
| #endif |
There was a problem hiding this comment.
I'd like to propose a wider scope for the use of port expanders in meshtastic. Which chip do you use exactly?
Suggestion would be to leave this as-is and replace later with proper handling of port expanders.
There was a problem hiding this comment.
That feels like a much better solution than the hacky way I have implemented it so far. Unphone uses TCA9555 which is a popular choice of expander.
I would be happy to help implementing this correctly.
Issues.txt
Outdated
| Utilise RGB led for notifications modules/ExternalNotificationModule.cpp AmbientLightingThread.h | ||
| Utilise Vibration for notifications modules/ExternalNotificationModule.cpp | ||
| Use accelerometer/compass Configuration.h, main.cpp, add library | ||
| use IR leds new code! |
There was a problem hiding this comment.
Please make sure the Todo list is not in the final commit :-)
|
So far this is looking great. Support for a compass module is something we're already looking at adding, so some great cross-pollination there. It would probably be good to get a unit to a developer or two. |
See PR meshtastic/firmware#3530 to main meshtastic firmware.
Thanks, sorry I was mistaken and it's only an accelerometer and gyroscope not a full compass, sadly. We will email you to setup sending out a couple of units to developers. |
|
Thanks for the advice and suggestions, I will now close this draft and prepare another PR incorporating the changes. |
Hello
I've been encouraged on Discord to put in this early PR, so I can get feedback without going too far wrong!
I have helped develop the unPhone (website shop link). It's got a 480x320 touchscreen, RFM95W 868MHz LoRa, battery, accelerometer/compass, sd card, RGB and IR LED's, & vibration feedback. Now I am porting the rather fantastic Meshtastic firmware to our device.
I've got the screen, radio and sd card (seemingly) working in this PR. I had to make very minor changes to files in /graphics to use large fonts, a small bit of setup in main.cpp because our device has the backlight on a I2C expander. The main additions in this PR are the creation of a new variant.h and platformio.ini file for the new device, and a new driver configuration in graphics/TFTDisplay.cpp (using the existing LovyanGFX pattern).
I am requesting advice and guidance to make integrating these changes in the best way possible. For example, I believe the patterrn I have used for implementing HX8357 support for our device could be re-used by others.
Please accept my apologies if I've missed some guidance in preparing this PR - I am very keen to do this 'right' so just let me know if I should re-work anything etc!
We can supply hardware (gratis no obligations) to developers if that would be useful.