2.2.X Proposed Protobuf changes #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2.2.X Firmware working changes: meshtastic/firmware#2647 |
caveman99
approved these changes
Jul 27, 2023
Add last_rx_time and node_broadcast_interval_secs to Neighbor
andrekir
approved these changes
Aug 1, 2023
andrekir
added a commit
to meshtastic/Meshtastic-Android
that referenced
this pull request
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the device, we will incremement the DEVICESTATE_VERSION, so folks will need to re-provision their devices. This also gives you all on the app / client front a clean slate. Most of this is removing, not re-indexing deprecated protobufs. We'll save re-indexing for 3.0, since that will be a breaking change for the protocol. Clients need to source some of the removed fields from MyNodeInfo on DeviceMetadata now
This shouldn't be a breaking change, per-se except for the device which as I mentioned will incremement the DEVICESTATE_VERSION and reprovision. Some clients may respond differently to the removal of protobuf fields, so I'm not entirely sure how that looks in each one. In any account, apps / clients will need to do the minimum version prompt when attempting to pair 2.0/2.1x devices to ensure that things move forward. I think it should be a pretty smooth transition.
If it doesn't work out on the field removal front in MyNodeInfo, we can go back on that. My preference was to remove those before 3.0, to slowly transition to phasing those fields out rather than completely gutting like we did from 1.2 to 2.0, which placed a large burden on all of the clients.