Skip to content

Conversation

MaxandreOgeret
Copy link
Contributor

#fix #14981

It adds a new function in the cuda target: _detect_target_path.
And it will search the SBSA target path correctly on aarch64 machines.

Same logic as https://github.com/NVIDIA/cuda-samples/blob/3f1c50965017932fc81e6d94a3fc9e04c105b312/cmake/toolchains/toolchain-aarch64-linux.cmake#L18

Todo:

  • Add Arm64 SBSA cuda test

Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small implementation nit, otherwise that part looks good.

It would be great to have a test for this as you noted. I'm not sure what our aarch64 CI situation is like these days.

@MaxandreOgeret
Copy link
Contributor Author

MaxandreOgeret commented Sep 21, 2025

One small implementation nit, otherwise that part looks good.

It would be great to have a test for this as you noted. I'm not sure what our aarch64 CI situation is like these days.

Hey @dcbaker ! Thanks for the review.
I had a talk with @eli-schwartz about aarch64 CI, and the idea was to add a aarch64 docker image and run tests there.
I experimented that in my fork here: MaxandreOgeret@e35c9fd using the ubuntu-24.04-arm runner. But the availability of this runner is sporadic it seems.

Have you thought about it, do you have any hints ?

@dcbaker
Copy link
Member

dcbaker commented Sep 22, 2025

Eli knows a lot more about how the CI infrastructure works to be honest, and I'd be inclined to defer to his judgement on what we should do there.

I'm happy with the implementation at this point, so I'm fine with merging this now and figuring out CI later, let's see what Eli says.

@bonzini
Copy link
Collaborator

bonzini commented Sep 22, 2025

@MaxandreOgeret can you rebase to clean CI?

@MaxandreOgeret
Copy link
Contributor Author

Should be good now

@dcbaker dcbaker merged commit 55c8d6e into mesonbuild:master Sep 22, 2025
32 checks passed
@MaxandreOgeret MaxandreOgeret deleted the cuda/sbsa_compat branch September 23, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Cuda SBSA build do not work since 1.9.0
3 participants