Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug configuration providers #256

Merged
merged 4 commits into from
Aug 16, 2024

Commits on Aug 8, 2024

  1. debug: fix list of debug configurations for C++ (GDB/LLDB) debugger

    createDebugConfiguration is silently failing returning an empty
    list of debug configurations.
    ylatuya committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2aea915 View commit details
    Browse the repository at this point in the history
  2. debug: fix DebugConfigurationProvider registration

    We are incorrectly registering a single debug provider that provides
    `cppdbg` and `cppvsdbg` configurations using the `cppdbg` type.
    
    Split the cppdb and cppvsdbg debug providers into 2 different providers
    and register them based on the current operating system following the
    same approach as the `ms-vscode.cpptools` extension.
    
    Also simplify the debug providers into a single MesonDebugProvider
    class.
    ylatuya committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    65bfd5b View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. debug: register providers only if the debugger extension is installed

    Providing debug configurations if the debugger extension is not
    installed has 2 problems:
      * The debug configuration is listed in a menu item named "undefined"
      * The launch configuration will not work because the debugger does not
        exists
    ylatuya committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a756e9b View commit details
    Browse the repository at this point in the history
  2. debug: use lldb or gdb for cppdbg using the OS defaults

    We shouldn't infer what debugger to use based on the compiler
    command. Instead we use the defaults based on the OS:
    https://code.visualstudio.com/docs/cpp/launch-json-reference#_mimode
    ylatuya committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    37278d5 View commit details
    Browse the repository at this point in the history