Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixman: update to 0.43.2 #1358

Merged
merged 1 commit into from
Jan 30, 2024
Merged

pixman: update to 0.43.2 #1358

merged 1 commit into from
Jan 30, 2024

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Jan 6, 2024

Marking draft for now, in hope of clarification on whether this is a stable release.

@bgilbert
Copy link
Contributor Author

No official clarification from upstream, either in the issue or a mailing list thread. However, releases with odd minor numbers automatically enable some debug code which claims to have performance consequences, so it seems safest to treat this as a development release and not package it.

I'll leave this PR open as documentation unless wrapdb maintainers would prefer otherwise.

@bgilbert bgilbert changed the title pixman: update to 0.43.0 pixman: update to 0.43.2 Jan 28, 2024
@bgilbert bgilbert marked this pull request as ready for review January 28, 2024 14:15
@bgilbert
Copy link
Contributor Author

Bumped to 0.43.2. Per this PR, odd minors are no longer development releases, and the corresponding debug code has been removed.

This should be ready for review.

@jpakkane
Copy link
Member

pixman| Project name: pixman
pixman| Project version: 0.43.2
pixman| DEPRECATION: None of the values ['gnu99'] are supported by the c compiler.
pixman| However, the deprecated gnu99 std currently falls back to c99.
pixman| This will be an error in the future.
pixman| If the project supports both GNU and MSVC compilers, a value such as
pixman| "c_std=gnu11,c11" specifies that GNU is prefered but it can safely fallback to plain c11.

subprojects\pixman-0.43.2\meson.build:21:0: ERROR: Fatal warnings enabled, aborting

@bgilbert
Copy link
Contributor Author

wrapdb CI is going to see that failure a lot, I think. c_std=gnu11,c11 requires Meson ≥ 1.3.0, and many projects may want to continue supporting older Meson.

@neheb
Copy link
Collaborator

neheb commented Jan 28, 2024

wonder if it's possible for CI to fail for wraps that have custom meson.build files only.

@neheb neheb merged commit 730161e into mesonbuild:master Jan 30, 2024
6 of 8 checks passed
@bgilbert bgilbert deleted the pixman branch January 30, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants