Skip to content

Do not send zero-datetime (0001-01-01T00:00:00Z) if not set #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Do not send zero-datetime (0001-01-01T00:00:00Z) if not set #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ff0795
Do not send zero-datetime (0001-01-01T00:00:00Z) if not set
Jul 7, 2021
ffc5cb9
Merge branch 'master' into master
rfeiner Jul 12, 2022
1261a4b
Fix test
Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion voicemessage/voice_message.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ func paramsToRequest(recipients []string, body string, params *Params) (*voiceMe
request.Voice = params.Voice
request.Repeat = params.Repeat
request.IfMachine = params.IfMachine
request.ScheduledDatetime = params.ScheduledDatetime.Format(time.RFC3339)
if !params.ScheduledDatetime.IsZero() {
request.ScheduledDatetime = params.ScheduledDatetime.Format(time.RFC3339)
}

return request, nil
}
12 changes: 11 additions & 1 deletion voicemessage/voice_message_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"testing"
"time"

"github.com/messagebird/go-rest-api/v9"
messagebird "github.com/messagebird/go-rest-api/v9"
"github.com/messagebird/go-rest-api/v9/internal/mbtest"
"github.com/stretchr/testify/assert"
)
Expand Down Expand Up @@ -124,3 +124,13 @@ func TestRequestDataForVoiceMessage(t *testing.T) {
assert.Equal(t, "continue", request.IfMachine)
assert.Equal(t, voiceParams.ScheduledDatetime.Format(time.RFC3339), request.ScheduledDatetime)
}

func TestRequestDataForVoiceMessageZeroScheduledDatetime(t *testing.T) {
voiceParams := &Params{
// ScheduledDatetime will default to zero-time
}

request, err := paramsToRequest([]string{"31612345678"}, "MyBody", voiceParams)
assert.NoError(t, err)
assert.Equal(t, "", request.ScheduledDatetime, "Uninitialized ScheduledDatetime should default to empty string")
}