Only format ScheduledDateTime if it has been set when generating message request data #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the message param's ScheduledDateTime from message if it hasn't been set
|
This resolves message delivery latency issues as the ScheduledDateTime was being sent in the message request regardless of weather ScheduledDateTime was explicitly. |
azmb
suggested changes
Jan 23, 2018
message.go
Outdated
| @@ -102,12 +102,16 @@ func requestDataForMessage(originator string, recipients []string, body string, | |||
| } else { | |||
| request.MClass = 1 | |||
| } | |||
|
|
|||
| if params.ScheduledDatetime.IsZero() == false { | |||
There was a problem hiding this comment.
To make it consistent with our existing code base, would you mind simplifying if statement:
if !params.ScheduledDatetime.IsZero() {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating request data for a message, do not attempt to format the message param's ScheduledDateTime from message if it hasn't been set.