Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of parsing the Java version assumes that all Java versions returned by
System.getProperty("java.version")
will be inMAJOR.MINOR.PATCH
format (e.g21.0.2
), while this is incorrect.This breaks on versions that do not follow this format - for example, JDK 21+35 returns
21
.This is causing two issues:
> 1.6
- hereUser-agent
header - hereThis PR changes version parsing to use a versioning abstraction that is
Comparable
- I chose to use the existing implementation frommaven-artifacts
I've tried to write some tests for this but to be honest I don't find the
MessageBirdServiceImpl
class very unit-testable, so I ended up not writing a unit test for this.