Introduce objects/methods for dealing with voice call recordings #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [FIXES] the `call_list` method to access the proper endpoint - [ADDS] the `call_leg_list` method to request the call legs - [ADDS] the `call_leg_recording_list` to request the recordings for a leg - [ADDS] the `call_leg_recording_view` to view the details for one recording - [ADDS] the `call_leg_recording_download` call to download a recording - [ADDS] tests for the new methods
- restore the libdir thing - load messagebird/version in the main library
tsyber1an
reviewed
Dec 5, 2019
tsyber1an
reviewed
Dec 5, 2019
- Extract the `underscoring` func into `map_hash_elements_to_self` - Make MessageBird::Voice::List use `map_hash_elements_to_self` for pagination block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CHANGES] Namespace for Call object to MessageBird::Voice
[ADDS] New MessageBird::Voice::Base class for voice-related entities
[CHANGES] Request for
call_listgoes through MessageBird::VoiceClient[CHANGES] CallList -> MessageBird::Voice::List
[ADDS]
call_leg_listmethod + test[ADDS]
call_leg_recordings_listmethod + test[ADDS]
call_leg_recording_viewmethod + test[ADDS]
call_leg_recording_downloadmethod + test[ADDS] MessageBird::HttpClient::request_block method to perform a request and handle downloading in the provided Ruby block
[ADDS] New examples for calls, call_leg and call_leg_recordings
This will clash with #38 so I'm waiting for that work to complete to finish this.