Skip to content

Conversation

saitcakmak
Copy link
Contributor

Motivation

As noted in #1206, current conda installation instructions do not work for latest versions since the listed channels cannot resolve the pyro-ppl dependency. This updates the instructions to include the conda-forge channel as a fix.

Note: Technically conda-forge has botorch and gpytorch as well, so we could get away without including -c pytorch and -c gpytorch. However, conda-forge versions of these packages may not always be up-to-date, so keeping these channels makes sure we can always install the latest versions.

Test Plan

./scripts/build_docs.sh

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 5, 2022
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1207 (9468bb8) into main (0080c89) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         115      115           
  Lines       10176    10176           
=======================================
  Hits        10175    10175           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0080c89...9468bb8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants