fix constraint handling in single objective MBM #1973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48176978 |
Codecov Report
@@ Coverage Diff @@
## main #1973 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 178 178
Lines 15727 15721 -6
=========================================
- Hits 15727 15721 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 9, 2023
Summary: Pull Request resolved: facebook#1771 X-link: meta-pytorch/botorch#1973 Currently, constraints are not used in single objective AFs in MBM due to a name mismatch between `outcome_constraints` and `constraints`. Reviewed By: SebastianAment Differential Revision: D48176978 fbshipit-source-id: bae51fcd8740e2523e17d671f50384e7af19c17c
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Aug 9, 2023
Summary: X-link: facebook/Ax#1771 Pull Request resolved: meta-pytorch#1973 Currently, constraints are not used in single objective AFs in MBM due to a name mismatch between `outcome_constraints` and `constraints`. Reviewed By: SebastianAment Differential Revision: D48176978 fbshipit-source-id: 127713aefe63e9127267b8d9092979b56f290596
sdaulton
force-pushed
the
export-D48176978
branch
from
1f4b150 to
8142929
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48176978 |
Summary: X-link: facebook/Ax#1771 Pull Request resolved: meta-pytorch#1973 Currently, constraints are not used in single objective AFs in MBM due to a name mismatch between `outcome_constraints` and `constraints`. Reviewed By: SebastianAment Differential Revision: D48176978 fbshipit-source-id: 8e32f152d511d7dca4d9266dba47fc2765c37eae
sdaulton
force-pushed
the
export-D48176978
branch
from
8142929 to
d42b592
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48176978 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 10, 2023
Summary: Pull Request resolved: facebook#1771 X-link: meta-pytorch/botorch#1973 Currently, constraints are not used in single objective AFs in MBM due to a name mismatch between `outcome_constraints` and `constraints`. Reviewed By: SebastianAment Differential Revision: D48176978 fbshipit-source-id: 07ed85bf0b04354342a2765c9444bb546677d79f
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Aug 10, 2023
Summary: Pull Request resolved: #1771 X-link: meta-pytorch/botorch#1973 Currently, constraints are not used in single objective AFs in MBM due to a name mismatch between `outcome_constraints` and `constraints`. Reviewed By: SebastianAment Differential Revision: D48176978 fbshipit-source-id: 9495708002c11a874bb6b8c06327f0f4643039df
|
This pull request has been merged in 52529e1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently, constraints are not used in single objective AFs in MBM due to a name mismatch between
outcome_constraintsandconstraints.Reviewed By: SebastianAment
Differential Revision: D48176978