Add X as optional arg to call signature of MCAcqusitionObjective #664
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D25938012 |
…a-pytorch#664) Summary: Pull Request resolved: meta-pytorch#664 This was requested in meta-pytorch#663. Differential Revision: D25938012 fbshipit-source-id: ce293a3007d3b5c075d1f0c35f46e2f9a62106b4
Balandat
force-pushed
the
export-D25938012
branch
from
2fa020d to
24ed31d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25938012 |
|
@jduerholt do the changes in this PR work for you? |
…a-pytorch#664) Summary: Pull Request resolved: meta-pytorch#664 This was requested in meta-pytorch#663. Differential Revision: D25938012 fbshipit-source-id: d282f3b88777b08eee6f516c2f1a7a788f8f8e42
Balandat
force-pushed
the
export-D25938012
branch
from
24ed31d to
a71a6e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25938012 |
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 98 98
Lines 6591 6596 +5
=========================================
+ Hits 6591 6596 +5
Continue to review full report at Codecov.
|
|
Hi @Balandat, this looks exactly like what I need. I will test it over the course of the week. The intention of my issue from Friday was not that you should implement it on the weekend ... Thank you very much! Best, Johannes |
…a-pytorch#664) Summary: Pull Request resolved: meta-pytorch#664 This was requested in meta-pytorch#663. Differential Revision: D25938012 fbshipit-source-id: 7411b7eb29f50f576ca14ce0abdaa936440f83e4
|
This pull request was exported from Phabricator. Differential Revision: D25938012 |
Balandat
force-pushed
the
export-D25938012
branch
from
a71a6e6 to
ce10c67
Compare
|
@jduerholt any updates? FWIW I'm planning to cut a new release soon, if this works for you I'll include this PR. |
|
Hi @Balandat, sorry for not responding yet. I was so busy with other things that I could not find the time to test it so far. But my plan is to have a basic implementation and test in our workflow until the end of the week. Hope this works for you. Best, Johannes |
|
This pull request was exported from Phabricator. Differential Revision: D25938012 |
…a-pytorch#664) Summary: Pull Request resolved: meta-pytorch#664 This was requested in meta-pytorch#663. Reviewed By: qingfeng10 Differential Revision: D25938012 fbshipit-source-id: df7332f50c86c77b1caaf537b30ae5a6967854d3
Balandat
force-pushed
the
export-D25938012
branch
from
ce10c67 to
1c4567a
Compare
…a-pytorch#664) Summary: Pull Request resolved: meta-pytorch#664 This was requested in meta-pytorch#663. Reviewed By: qingfeng10 Differential Revision: D25938012 fbshipit-source-id: ba479eadd5712af57dca4955e6c4a4f2bd37bc47
Balandat
force-pushed
the
export-D25938012
branch
from
1c4567a to
8e9de64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25938012 |
…a-pytorch#664) Summary: Pull Request resolved: meta-pytorch#664 This was requested in meta-pytorch#663. Reviewed By: qingfeng10 Differential Revision: D25938012 fbshipit-source-id: dfdb0627429d5e1c7979948d1c8152f7c56c9f3c
Balandat
force-pushed
the
export-D25938012
branch
from
8e9de64 to
2c0aa61
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25938012 |
…ebook#664) Summary: Pull Request resolved: meta-pytorch/botorch#664 This was requested in meta-pytorch/botorch#663. Reviewed By: qingfeng10 Differential Revision: D25938012 fbshipit-source-id: 35f3327db8d8f8cea74be73c83fda7218f89c070
…a-pytorch#664) Summary: Pull Request resolved: meta-pytorch#664 This was requested in meta-pytorch#663. Reviewed By: qingfeng10 Differential Revision: D25938012 fbshipit-source-id: 051ab4883507f8b4241677717585cd57bc796845
Balandat
force-pushed
the
export-D25938012
branch
from
2c0aa61 to
b874c4a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25938012 |
|
Hi @Balandat I see you are very active here. I tested the feature today in a single objective setup (no qehvi). Works like a charm! Multiobjective will be tested next week, but I do not expect any problems. So from my side it could and should be included in the next release ;-) Have a nice weekend and many thanks! Best, Johannes |
|
Great, thanks for the feedback. Will merge this in shortly. |
|
This pull request has been merged in 8274411. |
Summary: Pull Request resolved: #487 Pull Request resolved: meta-pytorch/botorch#664 This was requested in meta-pytorch/botorch#663. Reviewed By: qingfeng10 Differential Revision: D25938012 fbshipit-source-id: c47db2ec449eb598cec383965e95622beefeddef
3 participants
Summary: This was requested in #663.
Differential Revision: D25938012