Specify use_cpu as bool for datasets #1259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D55167566 |
cicichen01
force-pushed
the
export-D55167566
branch
from
e24a9dd to
12676f6
Compare
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. use_cpu is supposed to be a bool for datasets. However, it was combined with gpu settings with more informations inside. We separate the variable to clarify the logic. This change also removes the duplicated data adjust for gpu. Differential Revision: D55167566
|
This pull request was exported from Phabricator. Differential Revision: D55167566 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. use_cpu is supposed to be a bool for datasets. However, it was combined with gpu settings with more informations inside. We separate the variable to clarify the logic. This change also removes the duplicated data adjust for gpu. Differential Revision: D55167566
cicichen01
force-pushed
the
export-D55167566
branch
from
12676f6 to
206f696
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55167566 |
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
Summary: As titled. use_cpu is supposed to be a bool for datasets. However, it was combined with gpu settings with more informations inside. We separate the variable to clarify the logic. This change also removes the duplicated data adjust for gpu. Differential Revision: D55167566
cicichen01
force-pushed
the
export-D55167566
branch
from
206f696 to
b5a9ad9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55167566 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. use_cpu is supposed to be a bool for datasets. However, it was combined with gpu settings with more informations inside. We separate the variable to clarify the logic. This change also removes the duplicated data adjust for gpu. Differential Revision: D55167566
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 23, 2024
Summary: As titled. use_cpu is supposed to be a bool for datasets. However, it was combined with gpu settings with more informations inside. We separate the variable to clarify the logic. This change also removes the duplicated data adjust for gpu. Differential Revision: D55167566
|
This pull request has been merged in 724e9a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. use_cpu is supposed to be a bool for datasets. However, it was combined with gpu settings with more informations inside. We separate the variable to clarify the logic.
This change also removes the duplicated data adjust for gpu.
Differential Revision: D55167566