Fixing flaky test #780
Closed
Fixing flaky test #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @vivekmig |
|
Looks great, thanks so much for this fix @crawlingcub ! |
|
@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running some tests by removing seeds revealed that tests such as
test_single_shapley_int_batch_scalar_float,test_single_shapley_int_batch_scalar_tensor_0d,test_single_shapley_int_batch_scalar_tensor_1d, andtest_single_shapley_int_batch_scalar_tensor_intare flaky. They almost fail 40-50% of the times.To fix these tests, I updated the
n_samplesto 2500 to fix the flakiness. The tests now pass consistently. This only affects the execution time of the test by ~1s.Please let me know if this change seems reasonable. Similar to #775.