(3/n torchx-allocator)(monarch/tools) add commands.server_ready function and hostnames to mesh_spec #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76847192 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Differential Revision: D76847192
kiukchung
added a commit
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
added a commit
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
force-pushed
the
export-D76847192
branch
from
a6fd688 to
4b01216
Compare
kiukchung
added a commit
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
force-pushed
the
export-D76847192
branch
from
4b01216 to
68148d5
Compare
kiukchung
added a commit
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
|
This pull request was exported from Phabricator. Differential Revision: D76847192 |
kiukchung
added a commit
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: Pull Request resolved: #296 TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
kiukchung
force-pushed
the
export-D76847192
branch
from
68148d5 to
e07fea6
Compare
…ion and hostnames to mesh_spec (#296) Summary: Pull Request resolved: #296 TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
|
This pull request was exported from Phabricator. Differential Revision: D76847192 |
kiukchung
force-pushed
the
export-D76847192
branch
from
e07fea6 to
6fbe9ba
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
…ion and hostnames to mesh_spec (#296) Summary: TorchX's `status` API returns a struct that has `replica.hostname` field. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information. This PR adds a `hostnames` field to `monarch.tools.mesh_sepc.MeshSpec` and fills it up with the hostnames returned by TorchX. This information will be used in PR (5/n) to implement a `TorchXAllocator` Reviewed By: suo Differential Revision: D76847192
|
This pull request has been merged in 844e0bb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TorchX's
statusAPI returns a struct that hasreplica.hostnamefield. However it is not always filled for all schedulers. meta-pytorch/torchx#1080 makes it such that the slurm scheduler in TorchX fills out the hostname information.This PR adds a
hostnamesfield tomonarch.tools.mesh_sepc.MeshSpecand fills it up with the hostnames returned by TorchX.This information will be used in PR (5/n) to implement a
TorchXAllocatorDifferential Revision: D76847192