Reapply "[Windows] Fix build issues using Clang-CL on Windows, add CI… #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
Importing to verify lint fix. |
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D83882623. |
GregoryComer
force-pushed
the
reapply-windows
branch
from
089a04a to
157d557
Compare
meta-pytorch#135) Summary: … (meta-pytorch#121)" (meta-pytorch#134) Re-apply Windows changes with lint fix. See the original PR (meta-pytorch#121) for more details. This PR is identical, except for remove a space before a `#pragma` in compiler.h. Differential Revision: D83882623 Pulled By: GregoryComer
GregoryComer
force-pushed
the
reapply-windows
branch
from
157d557 to
f516e91
Compare
|
@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83882623. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#121)" (#134)
Re-apply Windows changes with lint fix. See the original PR (#121) for more details. This PR is identical, except for removing extra whitespace in compiler.h.