Skip to content

Commit ee77f57

Browse files
Dan-FloresDaniel Flores
andauthored
Replace frame 289 with the correct last frame 389 (#876)
Co-authored-by: Daniel Flores <danielflores3@fb.com>
1 parent c2e202d commit ee77f57

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

test/resources/nasa_13013.mp4.stream3.frame000289.pt

Lines changed: 0 additions & 1 deletion
This file was deleted.

test/test_decoders.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def test_getitem_int(self, num_ffmpeg_threads, device, seek_mode):
180180
ref_frame0 = NASA_VIDEO.get_frame_data_by_index(0).to(device)
181181
ref_frame1 = NASA_VIDEO.get_frame_data_by_index(1).to(device)
182182
ref_frame180 = NASA_VIDEO.get_frame_data_by_index(180).to(device)
183-
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(289).to(device)
183+
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(389).to(device)
184184

185185
assert_frames_equal(ref_frame0, decoder[0])
186186
assert_frames_equal(ref_frame1, decoder[1])
@@ -193,7 +193,7 @@ def test_getitem_numpy_int(self):
193193
ref_frame0 = NASA_VIDEO.get_frame_data_by_index(0)
194194
ref_frame1 = NASA_VIDEO.get_frame_data_by_index(1)
195195
ref_frame180 = NASA_VIDEO.get_frame_data_by_index(180)
196-
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(289)
196+
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(389)
197197

198198
# test against numpy.int64
199199
assert_frames_equal(ref_frame0, decoder[numpy.int64(0)])
@@ -404,7 +404,7 @@ def test_iteration(self, device, seek_mode):
404404
ref_frame9 = NASA_VIDEO.get_frame_data_by_index(9).to(device)
405405
ref_frame35 = NASA_VIDEO.get_frame_data_by_index(35).to(device)
406406
ref_frame180 = NASA_VIDEO.get_frame_data_by_index(180).to(device)
407-
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(289).to(device)
407+
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(389).to(device)
408408

409409
# Access an arbitrary frame to make sure that the later iteration
410410
# still works as expected. The underlying C++ decoder object is

test/test_ops.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ def test_throws_exception_at_eof(self, device):
337337

338338
seek_to_pts(decoder, 12.979633)
339339
last_frame, _, _ = get_next_frame(decoder)
340-
reference_last_frame = NASA_VIDEO.get_frame_data_by_index(289)
340+
reference_last_frame = NASA_VIDEO.get_frame_data_by_index(389)
341341
assert_frames_equal(last_frame, reference_last_frame.to(device))
342342
with pytest.raises(IndexError, match="no more frames"):
343343
get_next_frame(decoder)
@@ -1059,7 +1059,7 @@ def seek(self, offset: int, whence: int) -> int:
10591059
seek_to_pts(decoder, 12.979633)
10601060

10611061
frame_last, *_ = get_next_frame(decoder)
1062-
reference_frame_last = NASA_VIDEO.get_frame_data_by_index(289)
1062+
reference_frame_last = NASA_VIDEO.get_frame_data_by_index(389)
10631063
assert_frames_equal(frame_last, reference_frame_last.to(device))
10641064

10651065
assert file_counter.num_seeks > initialization_seeks

0 commit comments

Comments
 (0)