[torchcodec] Add CUDA support to SimpleVideoDecoder #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60676983 |
|
This pull request was exported from Phabricator. Differential Revision: D60676983 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: meta-pytorch#146 Add a device type to the SimpleVideoDecoder constructor that defaults to the CPU device. Use 1 CPU FFMPEG thread when using CUDA decoding because it seems to hurt performance to use multiple threads. We could expose thread_count in SimpleVideoDecoder in a subsequent diff if need be. Differential Revision: D60676983
ahmadsharif1
force-pushed
the
export-D60676983
branch
from
19c098b to
ff69a30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60676983 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: meta-pytorch#146 Add a device type to the SimpleVideoDecoder constructor that defaults to the CPU device. Use 1 CPU FFMPEG thread when using CUDA decoding because it seems to hurt performance to use multiple threads. We could expose thread_count in SimpleVideoDecoder in a subsequent diff if need be. Differential Revision: D60676983
ahmadsharif1
force-pushed
the
export-D60676983
branch
from
ff69a30 to
28022fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60676983 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: meta-pytorch#146 Add a device type to the SimpleVideoDecoder constructor that defaults to the CPU device. Use 1 CPU FFMPEG thread when using CUDA decoding because it seems to hurt performance to use multiple threads. We could expose thread_count in SimpleVideoDecoder in a subsequent diff if need be. Differential Revision: D60676983
ahmadsharif1
force-pushed
the
export-D60676983
branch
from
28022fc to
ba263aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60676983 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: meta-pytorch#146 Add a device type to the SimpleVideoDecoder constructor that defaults to the CPU device. Use 1 CPU FFMPEG thread when using CUDA decoding because it seems to hurt performance to use multiple threads. We could expose thread_count in SimpleVideoDecoder in a subsequent diff if need be. Reviewed By: scotts Differential Revision: D60676983
ahmadsharif1
force-pushed
the
export-D60676983
branch
from
ba263aa to
176cd80
Compare
Summary: Pull Request resolved: meta-pytorch#146 Add a device type to the SimpleVideoDecoder constructor that defaults to the CPU device. Use 1 CPU FFMPEG thread when using CUDA decoding because it seems to hurt performance to use multiple threads. We could expose thread_count in SimpleVideoDecoder in a subsequent diff if need be. Reviewed By: scotts Differential Revision: D60676983
|
This pull request was exported from Phabricator. Differential Revision: D60676983 |
ahmadsharif1
force-pushed
the
export-D60676983
branch
from
176cd80 to
1ed8d45
Compare
|
This pull request has been merged in ec5e63a. |
ahmadsharif1
added a commit
that referenced
this pull request
Aug 15, 2024
This reverts commit ec5e63a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a device type to the SimpleVideoDecoder constructor that defaults to the CPU device.
Use 1 CPU FFMPEG thread when using CUDA decoding because it seems to hurt performance to use multiple threads.
We could expose thread_count in SimpleVideoDecoder in a subsequent diff if need be.
Differential Revision: D60676983