Refactor CUDA code into its own sets of files #193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
NicolasHug
reviewed
Aug 27, 2024
| torch::Tensor dummyTensorForCudaInitialization = torch::zeros( | ||
| {1}, | ||
| torch::TensorOptions().dtype(torch::kUInt8).device(device)); | ||
| codecContext->hw_device_ctx = av_buffer_ref(getCudaContext()); |
There was a problem hiding this comment.
Compilation is failing on this line with:
/pytorch/torchcodec/src/torchcodec/decoders/_core/CUDACommon.cpp:81:3: error: ‘codecContext’ was not declared in this scope; did you mean ‘AVCodecContext’?
https://github.com/pytorch/torchcodec/actions/runs/10570986466/job/29286351387?pr=193
There was a problem hiding this comment.
Yes, I'm working on compilation problems. I submitted a PR because the CI is the only way for me to test on GPUs right now.
scotts
changed the title
scotts
changed the title
|
@scotts has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Abandoning this PR because we are going to move CUDA changes off of main and onto a feature branch for now. I'll re-open this PR on the feature branch when we have it ready. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code in
VideoDecoder.cpphas a lot of#ifdef ENABLE_CUDAdirectly in functions. This refactor applies the following principles:VideoDecoder.cppshould not need#ifdef ENABLE_CUDAinside of it.