Skip to content

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Sep 24, 2024

We did not explicitly mention that we need PyTorch 2.4. It was only implied by telling folks to get the latest stable version of PyTorch.

I'm also doing some minor editing on the text to list requirements first, then ending with how to install TorchCodec.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 24, 2024
@scotts scotts marked this pull request as ready for review September 24, 2024 18:54
Copy link
Contributor

@ahmadsharif1 ahmadsharif1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you wrote is okay with me as well, but as a person who likes to skim, I always appreciate terse instructions that get to the point quickly without a lot of words. Instead of "first" "then", etc. I prefer numbered lists.

@facebook-github-bot
Copy link
Contributor

@scotts has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@scotts scotts merged commit 4a02eff into meta-pytorch:main Sep 25, 2024
22 checks passed
@scotts scotts deleted the readme branch September 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants