Add Nvidia licenses link to README.md #270
Conversation
facebook-github-bot
added
the
CLA Signed
README.md
Outdated
| If you build TorchCodec with ENABLE_CUDA=1 or use the CUDA-enabled release of | ||
| torchcodec please review |
There was a problem hiding this comment.
I think we should wait until we have cuda wheels before we mention the "CUDA-enabled release", otherwise this might be confusing for users?
| If you build TorchCodec with ENABLE_CUDA=1 or use the CUDA-enabled release of | |
| torchcodec please review | |
| If you build TorchCodec with ENABLE_CUDA=1, please review |
There was a problem hiding this comment.
I want to get the legal approval for it and not change it last minute. Hence I added a blanket clause. I can add a (when available) to it if you want.
There was a problem hiding this comment.
Can we get legal approval for the full sentence now, land with the suggestion, and re-add the "CUDA-enable release" at the time of release? It doesn't seem much more work than adding "when available" and then having to remove it?
There was a problem hiding this comment.
I am inclined not to change legally approved sentences.
We can delay merging this PR though
README.md
Outdated
| However, TorchCodec may be used with code not written by Meta which may be | ||
| distributed under different licenses. | ||
|
|
||
| For example, if you build TorchCodec with ENABLE_CUDA=1 or use the CUDA-enabled release of torchcodec, please review CUDA's license here: [Nvidia licenses](https://docs.nvidia.com/cuda/eula/index.html). |
There was a problem hiding this comment.
Consider keeping the line length similar to the rest
4 participants
No description provided.