Skip to content

Test CUDA APIs of VideoDecoder #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2024
Merged

Test CUDA APIs of VideoDecoder #349

merged 3 commits into from
Nov 11, 2024

Conversation

NicolasHug
Copy link
Contributor

This PR adds tests for the public methods of VideoDecoder when device="cuda".

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 8, 2024
ahmadsharif1
ahmadsharif1 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@ahmadsharif1 ahmadsharif1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment above 265 to say that not all GPUs support it so we are intentionally running it just on the CPU

@NicolasHug NicolasHug merged commit 91f1a6f into main Nov 11, 2024
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ahmadsharif1 ahmadsharif1 ahmadsharif1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasHug @ahmadsharif1 @facebook-github-bot