Do not re-use old sws context if parameters have changed #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65667262 |
romanmeta
added a commit
to romanmeta/torchcodec
that referenced
this pull request
Nov 8, 2024
…h#354) Summary: It is possible for a single video to have frames of different dimensions. Caching `SwsContext` across such frames results in all kinds of reliability issues (crashes, wrong data, etc.) This diff makes sure that we only reuse cached `SwsContext` if the arguments to `sws_getContext` are the same. Reviewed By: ahmadsharif1 Differential Revision: D65667262
romanmeta
force-pushed
the
export-D65667262
branch
from
953aa72 to
378f260
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65667262 |
romanmeta
added a commit
to romanmeta/torchcodec
that referenced
this pull request
Nov 8, 2024
…h#354) Summary: It is possible for a single video to have frames of different dimensions. Caching `SwsContext` across such frames results in all kinds of reliability issues (crashes, wrong data, etc.) This diff makes sure that we only reuse cached `SwsContext` if the arguments to `sws_getContext` are the same. Reviewed By: ahmadsharif1 Differential Revision: D65667262
romanmeta
force-pushed
the
export-D65667262
branch
from
378f260 to
9e915fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65667262 |
…h#354) Summary: It is possible for a single video to have frames of different dimensions. Caching `SwsContext` across such frames results in all kinds of reliability issues (crashes, wrong data, etc.) This diff makes sure that we only reuse cached `SwsContext` if the arguments to `sws_getContext` are the same. Reviewed By: ahmadsharif1 Differential Revision: D65667262
romanmeta
force-pushed
the
export-D65667262
branch
from
9e915fb to
7854aef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65667262 |
ahmadsharif1
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It is possible for a single video to have frames of different dimensions. Caching
SwsContextacross such frames results in all kinds of reliability issues (crashes, wrong data, etc.)This diff makes sure that we only reuse cached
SwsContextif the arguments tosws_getContextare the same.Reviewed By: ahmadsharif1
Differential Revision: D65667262