Use std::string_view instead of c10::string_view because the latter is being deprecated #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65830279 |
ahmadsharif1
changed the title
…src/torchcodec/decoders/_core/VideoDecoderOps.cpp (meta-pytorch#364) Summary: `c10::string_view` is being removed, so we need to migrate. Differential Revision: D65830279
ahmadsharif1
force-pushed
the
export-D65830279
branch
from
fe2e8a6 to
27844d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65830279 |
|
Addressed with #439. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
c10::string_viewis being removed, so we need to migrate.Differential Revision: D65830279