Let wheel names get the proper platform suffix #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Nov 13, 2024
NicolasHug
force-pushed
the
version_suffix
branch
from
c305b8b to
7b7293b
Compare
NicolasHug
added a commit
to NicolasHug/torchcodec
that referenced
this pull request
Nov 18, 2024
NicolasHug
added a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our uploaded wheels currently do not have some necessary suffixes: https://download.pytorch.org/whl/nightly/torchcodec/. See e.g.
TorchCodec-0.0.4.dev0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whlwhich is present 4 times (1 CPU + 3 CUDA versions). Those 4 wheels should have 4 different names so they can be properly installed by users. Compare it to torchvision which has all the necessary suffixes: https://download.pytorch.org/whl/nightly/torchvisionAfter (a lot of) digging, it appears we need to make the changes proposed in this PR. It's not pretty, but this is what the
test-infrasetup requires. TorchAudio and TorchVision have similar setups