Skip to content

Deactivate version symbol check #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Deactivate version symbol check #380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e8bfcc
Deactivate version symbol check
NicolasHug Nov 18, 2024
05de84a
Merge branch 'main' of github.com:pytorch/torchcodec into aelfjnaef
NicolasHug Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packaging/post_build_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,12 @@ assert_not_in_wheel $wheel_path "^benchmarks"
assert_not_in_wheel $wheel_path "^packaging"

if [[ "$unamestr" == 'Linux' ]]; then
# See invoked python script below for details about this check.
extracted_wheel_dir=$(mktemp -d)
unzip -q $wheel_path -d $extracted_wheel_dir
symbols_matches=$(find $extracted_wheel_dir | grep ".so$" | xargs objdump --syms | grep GLIBCXX_3.4.)
python packaging/check_glibcxx.py "$symbols_matches"
# TODO: Put this back with higher upper bound of version symbol.
# # See invoked python script below for details about this check.
# extracted_wheel_dir=$(mktemp -d)
# unzip -q $wheel_path -d $extracted_wheel_dir
# symbols_matches=$(find $extracted_wheel_dir | grep ".so$" | xargs objdump --syms | grep GLIBCXX_3.4.)
# python packaging/check_glibcxx.py "$symbols_matches"

echo "ls dist"
ls dist
Expand Down
Loading