Docs and README update #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Nov 20, 2024
| # :class:`~torchcodec.FrameBatch` objects respectively. | ||
| # :meth:`~torchcodec.decoders.VideoDecoder.get_frames_at` methods, which will | ||
| # return a :class:`~torchcodec.Frame` and :class:`~torchcodec.FrameBatch` | ||
| # objects respectively. |
There was a problem hiding this comment.
Here and below I just replaced get_frames_in_range with get_frames_at, and did the same for the pts-based APIs. I think these APIs are more useful to users than the range-based ones, so it makes sense to showcase them in our example IMO.
scotts
approved these changes
Nov 20, 2024
NicolasHug
added a commit
to NicolasHug/torchcodec
that referenced
this pull request
Nov 20, 2024
NicolasHug
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.