Skip to content

Remove createFrom functions in C++ #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Remove createFrom functions in C++ #485

merged 1 commit into from
Jan 28, 2025

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Jan 28, 2025

Completes the refactoring started in #434.

The createFrom() functions don't add any values, because the std::make_unique function already does a similar thing.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 28, 2025
NicolasHug
NicolasHug approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptively approving, as the only blocker probably is just the CI

@scotts scotts marked this pull request as ready for review January 28, 2025 13:52
@scotts scotts merged commit f46f64a into meta-pytorch:main Jan 28, 2025
44 checks passed
@scotts scotts deleted the rm_creates branch January 28, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scotts @NicolasHug @facebook-github-bot