Avoid receiving undesired packets #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
approved these changes
Feb 7, 2025
|
Great catch again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids receiving undesired packets when calling
av_read_frame(). This saves 643 useless packets from being received on our nasa video.I was hoping we could remove/simplify a bit our
do/whilehttps://github.com/pytorch/torchcodec/blob/b87f00d587843f02941fc12779e72a6fef094e19/src/torchcodec/decoders/_core/VideoDecoder.cpp#L1007
and just do
but while most tests are passing, some still fail. I suspect FFmpeg just doesn't fully respect the DISCARD flag under some specific conditions (that I haven't investigated).