Add libswresample to FFmpeg source build #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Mar 14, 2025
| avdevice=libavdevice.60 | ||
| avfilter=libavfilter.9 | ||
| swscale=libswscale.7 | ||
| swresample=libswresample.4 |
There was a problem hiding this comment.
Yup, it's version 4 twice in a row, this isn't a typo (logs were previously failing)!
NicolasHug
commented
Mar 14, 2025
| -id @rpath/${swresample}.dylib \ | ||
| ${prefix}/lib/${swresample}.dylib | ||
| ${otool} -l ${prefix}/lib/${swresample}.dylib | grep -B2 ${prefix} | ||
|
|
There was a problem hiding this comment.
There is only a dependency on avutil:
~/dev/torchcodec (add_swresample*) » ldd $CONDA_PREFIX/lib/libswresample.so | grep av nicolashug@nicolashug-fedora-PF2MMKSN
libavutil.so.58 => /home/nicolashug/.miniconda3/envs/codec/lib/./libavutil.so.58 (0x00007f2924800000)
I don't have access to a mac so I cannot provide the output of otool on the actual dylib as requested on #219 (comment), but that should be fine?
There was a problem hiding this comment.
If Mac wheel builds work on CI, we should be good.
Merged
scotts
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #219, but for libswresample which we'll use to resample audio and convert audio formats.
I took the liberty of pushing those builds to S3 already, and they work as expected as can be seen in #562 and #556