Fix first PTS bug #565
Merged
Fix first PTS bug #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
approved these changes
Mar 17, 2025
|
Great fix! This must have also been a problem with video as well, but we never had any examples that exposed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553.
The fix is just to set
as is done in
ffprobe(which, from #553 , was correct): https://github.com/FFmpeg/FFmpeg/blob/1eafbf820312d45b31907e16877ae780022598c4/fftools/ffprobe.c#L3974I looked and debugged with a source-build of
ffprobefor a bit, trying to see if it was doing something clever with frames / packets pts. But I couldn't find anything. And the above is the only thing I could find that we weren't already doing with the AVCodecContext. So, while I don't necessarily understand why this is a fix, I'm fairly confident that this is indeed the right fix.