Add get_all_samples()
method to AudioDecoder
#594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most common decoding pattern for audio will be to decode an entire stream at once. Right now, the main way to do this is to call
decoder.get_samples_played_in_range()
which is a awkward:range
featureThis PR introduces the
decoder.get_all_samples()
method which is a more natural alias, hopefully providing a better UX for the most common usage.