Skip to content

Remove our own manywheel fixup #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

Remove our own manywheel fixup #645

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
494c990
Remove our own manywheel fixup
scotts Apr 21, 2025
11e97f6
Preserve commented out code
scotts Apr 21, 2025
8376576
Comment out conditional
scotts Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions packaging/post_build_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,22 +37,14 @@ assert_not_in_wheel $wheel_path "^doc"
assert_not_in_wheel $wheel_path "^benchmarks"
assert_not_in_wheel $wheel_path "^packaging"

if [[ "$unamestr" == 'Linux' ]]; then
# TODO: Put this back with higher upper bound of version symbol.
# # See invoked python script below for details about this check.
# extracted_wheel_dir=$(mktemp -d)
# unzip -q $wheel_path -d $extracted_wheel_dir
# symbols_matches=$(find $extracted_wheel_dir | grep ".so$" | xargs objdump --syms | grep GLIBCXX_3.4.)
# python packaging/check_glibcxx.py "$symbols_matches"

echo "ls dist"
ls dist

old="linux_x86_64"
new="manylinux_2_17_x86_64.manylinux2014_x86_64"
echo "Replacing ${old} with ${new} in wheel name"
mv dist/*${old}*.whl $(echo dist/*${old}*.whl | sed "s/${old}/${new}/")
fi
# TODO: Put this back with higher upper bound of version symbol.
#if [[ "$unamestr" == 'Linux' ]]; then
# # See invoked python script below for details about this check.
# extracted_wheel_dir=$(mktemp -d)
# unzip -q $wheel_path -d $extracted_wheel_dir
# symbols_matches=$(find $extracted_wheel_dir | grep ".so$" | xargs objdump --syms | grep GLIBCXX_3.4.)
# python packaging/check_glibcxx.py "$symbols_matches"
#fi

echo "ls dist"
ls dist
Loading