Audio: Fix output shape when start==stop #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
reviewed
Apr 29, 2025
| if (stopSecondsOptional.has_value() && startSeconds == *stopSecondsOptional) { | ||
| // For consistency with video | ||
| return AudioFramesOutput{torch::empty({0, 0}), 0.0}; | ||
| auto numChannels = getNumChannels(streamInfo.codecContext); |
There was a problem hiding this comment.
Nit: I prefer we're explicit about our ints. It's just as easy to read.
scotts
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661
Output shape is now (num_channels, 0) instead of (0, 0). This is more consistent with the video decoder as well, so I think we can consider this a bug fix.