Skip to content

Remove obsolete stream_index from decoder benchmark calls #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Remove obsolete stream_index from decoder benchmark calls #780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e9f49
Remove obsolete `stream_index` from decoder benchmark calls
mrezabayat Jul 14, 2025
150fcfe
Fix linter
NicolasHug Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions benchmarks/decoders/benchmark_decoders_library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import abc
import json
import subprocess
import typing
import urllib.request
Expand All @@ -20,7 +19,6 @@
create_from_file,
get_frames_at_indices,
get_frames_by_pts,
get_json_metadata,
get_next_frame,
seek_to_pts,
)
Expand Down Expand Up @@ -238,11 +236,7 @@ def decode_frames(self, video_file, pts_list):
color_conversion_library=self._color_conversion_library,
device=self._device,
)
metadata = json.loads(get_json_metadata(decoder))
best_video_stream = metadata["bestVideoStreamIndex"]
frames, *_ = get_frames_by_pts(
decoder, stream_index=best_video_stream, timestamps=pts_list
)
frames, *_ = get_frames_by_pts(decoder, timestamps=pts_list)
return frames

def decode_first_n_frames(self, video_file, n):
Expand Down Expand Up @@ -356,11 +350,7 @@ def decode_frames(self, video_file, pts_list):
color_conversion_library=self._color_conversion_library,
device=self._device,
)
metadata = json.loads(get_json_metadata(decoder))
best_video_stream = metadata["bestVideoStreamIndex"]
frames, *_ = get_frames_by_pts(
decoder, stream_index=best_video_stream, timestamps=pts_list
)
frames, *_ = get_frames_by_pts(decoder, timestamps=pts_list)
return frames

def decode_first_n_frames(self, video_file, n):
Expand All @@ -371,12 +361,8 @@ def decode_first_n_frames(self, video_file, n):
color_conversion_library=self._color_conversion_library,
device=self._device,
)
metadata = json.loads(get_json_metadata(decoder))
best_video_stream = metadata["bestVideoStreamIndex"]
indices_list = list(range(n))
frames, *_ = get_frames_at_indices(
decoder, stream_index=best_video_stream, frame_indices=indices_list
)
frames, *_ = get_frames_at_indices(decoder, frame_indices=indices_list)
return frames


Expand Down
Loading