Improve pytest default options
#794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Dan-Flores
reviewed
Jul 31, 2025
| - name: Run Python tests | ||
| run: | | ||
| pytest test -vvv | ||
| pytest --override-ini="addopts=-v" test |
There was a problem hiding this comment.
Should the CI continue to use maximum verbosity?
There was a problem hiding this comment.
We've been using -v only for the CUDA tests already. Personally I find -vvv too versbose and thus difficult to debug, because the traceback is really long. Thank you for the review - I'll merge as-is, but I'm happy to put back -vvv if you prefer.
Dan-Flores
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a "slow" test that takes >1 minute to complete. I got a bit tired of having to always manually specify
-k "not slow"in my test options, so I made it the default: the tests that are marked as 'slow' are now skipped by default. We always run them in the CI though.Similarly, I always find myself having to add
-v, so it's now the default. I hope this isn't controversial.