Skip to content

Conversation

maksdamir
Copy link
Contributor

Current examples suggest seek api on file-like objects should return bytes, while actual usage always expects int instead.

For example: https://docs.python.org/3/library/io.html#io.IOBase.seek

seek(offset, whence=os.SEEK_SET, /)
Change the stream position to the given byte offset, interpreted relative to the position indicated by whence, and return the new absolute position.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 22, 2025
@facebook-github-bot
Copy link
Contributor

@maksdamir has imported this pull request. If you are a Meta employee, you can view this in D80807914.

Copy link
Contributor

@Dan-Flores Dan-Flores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the PR @maksdamir!

@scotts
Copy link
Contributor

scotts commented Aug 22, 2025

@maksdamir, wow, great catch, thank you!

@Dan-Flores Dan-Flores merged commit c8b6acf into meta-pytorch:main Aug 22, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants