Skip to content

Conversation

NicolasHug
Copy link
Contributor

@NicolasHug NicolasHug commented Aug 26, 2025

All builds started failing with:

/Users/ec2-user/runner/_work/torchcodec/torchcodec/pytorch/torchcodec/src/torchcodec/_core/custom_ops.cpp:87:47: error: must specify at least one argument for '...' parameter of variadic macro [-Werror,-Wgnu-zero-variadic-macro-arguments]
  TORCH_INTERNAL_ASSERT(tensor.is_contiguous());
                                              ^

Probably a BC-breaking change from torch? Anyway, we should probably rely on TORCH_CHECK rather than TORCH_INTERNAL_ASSERT regardless.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 26, 2025
@scotts
Copy link
Contributor

scotts commented Aug 26, 2025

Agreed on not using TORCH_INTERNAL_ASSERT - that's leftover from a long while ago.

@NicolasHug NicolasHug merged commit 276f2b5 into meta-pytorch:main Aug 26, 2025
24 of 28 checks passed
@NicolasHug NicolasHug deleted the fix_internal_assert branch August 26, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants