Assert deviceInterface_ exists when it should
#875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
commented
Sep 5, 2025
| TORCH_CHECK( | ||
| deviceInterface_ != nullptr, | ||
| "No device interface available for video decoding. This ", | ||
| "shouldn't happen, please report."); |
There was a problem hiding this comment.
The new TORCH_CHECK is important but just as important is the change of the else if into a simple else
There was a problem hiding this comment.
Can we also add TORCH_CHECK(streamInfo.avMediaType == AVMEDIA_TYPE_VIDEO)? I believe that is also assumed.
There was a problem hiding this comment.
It's true that this is assumed but I think we can skip the check in the function, because this is heavily validated upstream in all callers, e.g. by calling validateActiveStream(...);
No strong opinion, I can add the check in a follow-up if you think it's good to validate it here as well.
scotts
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.