Let get_frames_at and get_frames_played_at accept tensor indices
#880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
This was referenced Sep 8, 2025
scotts
approved these changes
Sep 8, 2025
NicolasHug
added a commit
to NicolasHug/torchcodec
that referenced
this pull request
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #877
decoder.get_frames_at(indices)was implicitly accepting tensorindicesbefore https://github.com/pytorch/torchcodec/pull/746/files#diff-4f95b28922233b6ec6f41a7264a5518af7ea7dfb11329b133d378f9701e3cad0L224-L227 .The type annotation clearly mentions
list[int]but passing a tensor was previously working, and some users are already depending on this behavior: the nightlies are currently breakingtransformersas reported in #877.To avoid breaking users in our next release, this PR re-enables tensor support in a non-optimal way. I am opening #879 to follow-up on this so we can officially and properly support tensors.