Skip to content

Make it more obvious old sampler is deprecated #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2025
Merged

Make it more obvious old sampler is deprecated #916

merged 3 commits into from
Oct 1, 2025

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Oct 1, 2025

This code isn't included in any releases or documented.

@scotts scotts marked this pull request as ready for review October 1, 2025 20:04
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 1, 2025
@facebook-github-bot
Copy link
Contributor

@scotts has imported this pull request. If you are a Meta employee, you can view this in D83688146.

@mollyxu mollyxu requested review from mollyxu and removed request for mollyxu October 1, 2025 20:31
@scotts scotts merged commit 37e361a into meta-pytorch:main Oct 1, 2025
50 of 51 checks passed
@scotts scotts deleted the deprecate_old_samplers branch October 1, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollyxu mollyxu mollyxu approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scotts @facebook-github-bot @mollyxu