BETA CUDA interface: H265 support #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
This was referenced Oct 3, 2025
scotts
reviewed
Oct 3, 2025
| // No bitstream filter needed for other codecs | ||
| // TODONVDEC P1 MPEG4 will need one! | ||
| break; | ||
| } |
There was a problem hiding this comment.
Nit: I would prefer putting this switching logic into a function - I know we have a style difference there. :) My rationale is that I find it useful to think in terms of pure functions when I can, and this can definitely be a pure function, and then we can simply say in this scope:
std::string filterName = toFilterName(codecPar->codec_id);There was a problem hiding this comment.
IIUC we'd need toFilterName to return "" when no match exist, and it would be up to the caller to check against that?
scotts
reviewed
Oct 3, 2025
| void initializeInterface(AVStream* stream) override; | ||
| void initializeInterface( | ||
| const AVStream* stream, | ||
| const UniqueDecodingAVFormatContext& avFormatCtx) override; |
There was a problem hiding this comment.
I just merged #902, so there's going to be merge conflicts. It should be easy to solve: we just rename initializeInterface() to initialize(), and keep the new param.
scotts
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for H265 videos. It also creates a new
initializeBSF()method: previously, we were hard-coding the BSF for H264. But H265 needs a different kind of BSF, and some format do not need any. So this PR allows for that more general logic.This PR is based on #917 so if it's not already merged, you can review it independently by looking at
12c75e7(#919)