BETA CUDA interface: integrate with our existing tests and fix EOF hang #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
force-pushed
the
nvdec-tests
branch
from
cc295eb to
f8f0402
Compare
NicolasHug
changed the title
scotts
reviewed
Oct 3, 2025
| # | ||
| # TODONVDEC P2: Find a less clunky way to test the BETA CUDA interface. It | ||
| # will ultimately depend on how we want to publicly expose it. | ||
| if device_str == "cuda:0:beta": |
There was a problem hiding this comment.
Does this mean that our testing will only work on CUDA device 0?
There was a problem hiding this comment.
kinda. It's more that this line makes the assumption that we only ever test the beta interface as cuda:0:beta and never as cuda:1:beta.
We've never tested anything on cuda:1 so far, even for the default interface, but if we ever do this will be a trivial fix.
scotts
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets our existing test suite check the BETA CUDA interface. The good news is that we pass the vast majority of the tests.
The two failures, which are currently skipped with P0 TODOs, are related to end-of-stream logic. I'll follow-up with that in another PR.EDIT: I ended up fixing them here. We now pass all the tests!This PR is based on #920, so to review it independently please look at
f8f0402(#921)