BETA CUDA interface: Cleanup EOF packet sending logic #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
force-pushed
the
nvdec-send-eof
branch
from
cbfaaa7 to
bc55810
Compare
scotts
reviewed
Oct 3, 2025
| false, "Send EOF packet not implemented for this device interface"); | ||
| return AVERROR(ENOSYS); | ||
| } | ||
|
|
There was a problem hiding this comment.
If SingleStreamDecoder doesn't need to call a member function, then maybe we don't need to make it a part of DeviceInterface? Since sendEOFPacket() is only called from within BetaCudaDeviceInterface, it feels more like an implementation detail for that device.
scotts
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cbfaaa7